Iceberg: Extended documentation for materialized view behavior #11696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulmako
changed the title
| the snapshot-ids of all the tables that are part of the materialized | ||
| view's query at that point. When the materialized view is queried, the snapshot-ids | ||
| are used to check if the data in the storage table is up to date. If the data is | ||
| outdated, the storage is considered stale and the materialized view will behave |
There was a problem hiding this comment.
If the data in the storage table is outdated, the materialized view will behave..
| query into the existing table. | ||
| query into the existing table. Refreshing the materialized view will also store | ||
| the snapshot-ids of all the tables that are part of the materialized | ||
| view's query at that point. When the materialized view is queried, the snapshot-ids |
There was a problem hiding this comment.
view's query at that point in materialized view metadata.
anjalinorwood
approved these changes
Mar 29, 2022
|
@raunaqmorarka, @anjalinorwood thanks for your feedback. I made the changes you suggested. Can you take another look? |
raunaqmorarka
approved these changes
Mar 31, 2022
anjalinorwood
approved these changes
Mar 31, 2022
|
@hashhar please merge this one if it looks okay to you |
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the documentation on iceberg materialized views. I recently dug deeper into understanding the behavior of views and materialized views on the iceberg connector and noticed a behavior I did not expect. After asking about the behavior in slack (see https://trinodb.slack.com/archives/CGB0QHWSW/p1647589373377379) @raunaqmorarka clarified it to me.
To prevent other users from getting hung up on this, I wrote some more phrases about the behavior in the iceberg connector documentation.
Related issues, pull requests, and links
Discussion in Slack
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: