Refactor TestMemoryManager.testOutOfMemoryKiller #11818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
If one query finishes successfully, give another query a chance to fail.
`assertNotNull` is redundant since we also do `assertEquals`.
findepi
force-pushed
the
findepi/improve-testOutOfMemoryKiller
branch
from
22cc8e3 to
f041992
Compare
It was observed on CI that test query may complete successfully. This may be because OOM killer has 5s minimal delay.
Within the test, one query should get killed, but the other may not be killed and run to completion. If the first submitted query happens to run successfully, the test takes longer to complete. Inspect queries in order of their completion, not submission.
findepi
force-pushed
the
findepi/improve-testOutOfMemoryKiller
branch
from
f041992 to
8eca03d
Compare
|
@losipiuk thanks for review. i added |
losipiuk
reviewed
Apr 6, 2022
| @@ -115,6 +116,12 @@ public void testOutOfMemoryKiller() | |||
| .buildOrThrow(); | |||
|
|
|||
| try (DistributedQueryRunner queryRunner = createQueryRunner(TINY_SESSION, properties)) { | |||
| queryRunner.installPlugin(new BlackHolePlugin()); | |||
There was a problem hiding this comment.
This may be because OOM killer has 5s minimal delay
This will be dropped (as does not play well with task-level retries. (part of #11800).
There was a problem hiding this comment.
Will the test be updated to use smaller delay? This could make the test run shorter.
Still, the change here should remain. If query can succeed in low number of seconds, this feels racy.
losipiuk
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't fix the #11016maybe fixes #11016