Fail query if we cannot allocate enough memory #11875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
force-pushed
the
lo/kill-task-when-no-more-memory-avail
branch
from
705cbb1 to
5204b66
Compare
|
On top of #11802 |
linzebing
approved these changes
Apr 11, 2022
arhimondr
approved these changes
Apr 11, 2022
losipiuk
force-pushed
the
lo/kill-task-when-no-more-memory-avail
branch
from
5204b66 to
47f49e3
Compare
|
rebased |
losipiuk
force-pushed
the
lo/kill-task-when-no-more-memory-avail
branch
from
47f49e3 to
d38bae3
Compare
…llocator It is convenient to have those two coupled so we can make use of workers memory pool information within ExponentialGrowthPartitionMemoryEstimator
losipiuk
force-pushed
the
lo/kill-task-when-no-more-memory-avail
branch
from
d38bae3 to
b76b141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of On top of #11802; just review 3 top commits
Description
Fail whole query if for a retry node allocator is not capable of allocating more memory than was reached in peak during previous attempt of retried task.
Improvement
Core engine
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: