Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iceberg entry in release note 376 #11892

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

KarlManong
Copy link
Contributor

@KarlManong KarlManong commented Apr 9, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
No. The doc.

How would you describe this change to a non-technical end user or system administrator?
fix wrong placement which should in iceberg entry

Related issues, pull requests, and links

fix #11890

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
(X) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(X) Release notes entries required with the following suggested text:

# 11890
* Fix Iceberg entry in release note 376. ({issue}`11890`)

@cla-bot
Copy link

cla-bot bot commented Apr 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you fix the commit title (not PR title) as below?
"Fix Iceberg entry in release note 376"

https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@ebyhr ebyhr changed the title fix #11890 Fix Iceberg entry in release note 376 Apr 9, 2022
@cla-bot
Copy link

cla-bot bot commented Apr 9, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@KarlManong
Copy link
Contributor Author

Thanks, could you fix the commit title (not PR title) as below? "Fix Iceberg entry in release note 376"

https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

ok

@ebyhr ebyhr merged commit 828a636 into trinodb:master Apr 9, 2022
@ebyhr
Copy link
Member

ebyhr commented Apr 9, 2022

cc: @martint @mosabua

@github-actions github-actions bot added this to the 377 milestone Apr 9, 2022
@KarlManong KarlManong deleted the fix/release-note branch April 9, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Fix Iceberg entry in release note 376
3 participants