Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ANSI-compliant trim function #11913

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

m57lyra
Copy link
Contributor

@m57lyra m57lyra commented Apr 12, 2022

Description

Add entry in string.rst for new ANSI-compliant trim() function from #11347

Is this change a fix, improvement, new feature, refactoring, or other?
It is documentation for #11347

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
No.

How would you describe this change to a non-technical end user or system administrator?
It is documentation.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 12, 2022
@m57lyra m57lyra requested review from mosabua and ebyhr April 12, 2022 16:06
@github-actions github-actions bot added the docs label Apr 12, 2022
@m57lyra m57lyra requested a review from martint April 12, 2022 18:32
docs/src/main/sphinx/functions/string.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/string.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/string.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/functions/string.rst Outdated Show resolved Hide resolved
@m57lyra m57lyra requested a review from ebyhr April 13, 2022 19:27
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now.

@martint martint merged commit 9cfd4ad into trinodb:master Apr 13, 2022
@github-actions github-actions bot added this to the 377 milestone Apr 13, 2022
@m57lyra m57lyra deleted the ab/ansi-trim-doc branch March 6, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants