Ignore views on information_schema.columns queries #11946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
reviewed
Apr 14, 2022
...src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Apr 15, 2022
...src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
delta-information-schema-columns-on-presence-of-hive-view
branch
from
1dc3c76 to
ba42b8c
Compare
findinpath
commented
Apr 19, 2022
...src/main/java/io/trino/plugin/deltalake/metastore/HiveMetastoreBackedDeltaLakeMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
changed the title
findinpath
force-pushed
the
delta-information-schema-columns-on-presence-of-hive-view
branch
from
ba42b8c to
ce1eb52
Compare
@findepi yes it is testable with AWS Glue infrastructure. Thanks for raising this point. |
findinpath
force-pushed
the
delta-information-schema-columns-on-presence-of-hive-view
branch
from
ce1eb52 to
bea1ef7
Compare
findepi
approved these changes
Apr 20, 2022
|
Test PR: #12046 (cc @ilfrin @nineinchnick for potentially streamlining this) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The queries on
delta.information_schema.columnsdon't work in the presence of a Hive view in the shared metastore service (HMS/Glue).On such queries the user receives:
This bugfix uses the same technique employed on the
Icebergconnnector for throwing aTableNotFoundExceptionwhich is catched onstreamTableColumns()method on theDeltaLakeMetadataso that views can be ignored.The PR depends on #11565 for testing
Fix
Delta Lake connector
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: