-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify when the shared secret is needed #12331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update as with comment and either get rid of unrelated changes or separate into two commits
38ced33
to
95c6072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great .. let's ship this.
95c6072
to
d29741f
Compare
Further clarification suggested by David is in place now. Lines 12-13 |
Can we get this merged now @electrum ? |
Description
Clarify that setting a shared secret is no longer optional for any authentication, and that configuring internal TLS communication is a separate and optional feature.
Related issues, pull requests, and links