Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when the shared secret is needed #12331

Merged
merged 1 commit into from
May 26, 2022

Conversation

Ordinant
Copy link
Member

@Ordinant Ordinant commented May 10, 2022

Description

Clarify that setting a shared secret is no longer optional for any authentication, and that configuring internal TLS communication is a separate and optional feature.

Is this change a fix, improvement, new feature, refactoring, or other?
Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Docs only

How would you describe this change to a non-technical end user or system administrator?
Doc clarification

Related issues, pull requests, and links

@cla-bot cla-bot bot added the cla-signed label May 10, 2022
@Ordinant Ordinant requested review from dain, mosabua and aakashnand May 10, 2022 22:01
@Ordinant Ordinant added the docs label May 10, 2022
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update as with comment and either get rid of unrelated changes or separate into two commits

docs/src/main/sphinx/security/internal-communication.rst Outdated Show resolved Hide resolved
@Ordinant Ordinant force-pushed the bw/clarify-shared-secret branch 4 times, most recently from 38ced33 to 95c6072 Compare May 12, 2022 21:18
@Ordinant Ordinant changed the title Clarify shared secret and standardize text Clarify when the shared secret is needed May 12, 2022
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great .. let's ship this.

@Ordinant Ordinant force-pushed the bw/clarify-shared-secret branch from 95c6072 to d29741f Compare May 20, 2022 19:21
@Ordinant
Copy link
Member Author

Further clarification suggested by David is in place now. Lines 12-13

@Ordinant Ordinant requested a review from electrum May 20, 2022 21:15
@mosabua
Copy link
Member

mosabua commented May 22, 2022

Can we get this merged now @electrum ?

@mosabua
Copy link
Member

mosabua commented May 25, 2022

@electrum @martint .. can we get this merged..

@martint martint merged commit 8d76faa into trinodb:master May 26, 2022
@github-actions github-actions bot added this to the 382 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants