Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge font size on tables in docs #12356

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

colebow
Copy link
Member

@colebow colebow commented May 12, 2022

Description

Font size in tables in docs is quite small, this is a simple CSS change to enhance readability. Screenshots in comments below.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Docs

How would you describe this change to a non-technical end user or system administrator?

We're improving the readability of docs.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 12, 2022
@github-actions github-actions bot added the docs label May 12, 2022
@colebow
Copy link
Member Author

colebow commented May 12, 2022

Before:
image
image
image

After:
image
image
image

@colebow colebow requested review from mosabua and electrum May 12, 2022 17:19
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ... much more readable when the text is the same size .. and we have a lot of useful info in the tables

@electrum electrum merged commit 29770ae into trinodb:master May 20, 2022
@github-actions github-actions bot added this to the 382 milestone May 20, 2022
@colebow colebow deleted the colebow/table-css branch May 31, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants