Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Presto to Trino in PostgreSql #12374

Merged
merged 1 commit into from
May 18, 2022
Merged

Update Presto to Trino in PostgreSql #12374

merged 1 commit into from
May 18, 2022

Conversation

polaris6
Copy link
Member

@polaris6 polaris6 commented May 13, 2022 •
edited
Loading

Description

Update Presto to Trino in PostgreSql

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label May 13, 2022
@polaris6 polaris6 requested review from ebyhr and hashhar May 14, 2022 00:31
@findepi findepi requested review from wendigo and leveyja May 16, 2022 12:10
@polaris6
Copy link
Member Author

Hi @wendigo @leveyja, could you please help me to review this PR when you have time? Thank you very much!

ebyhr
ebyhr reviewed May 17, 2022
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate PR for changes it has user impact?

plugin/trino-cassandra/src/main/java/io/trino/plugin/cassandra/CassandraMetadata.java Outdated Show resolved Hide resolved
service/trino-verifier/src/main/java/io/trino/verifier/TrinoVerifier.java Outdated Show resolved Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/jmx/JdbcClientStats.java Outdated Show resolved Hide resolved
@polaris6 polaris6 force-pushed the update-presto-to-trino branch from acadf69 to 2869a91 Compare May 18, 2022 00:08
@polaris6 polaris6 changed the title Update Presto to Trino Update Presto to Trino in PostgreSql May 18, 2022
@ebyhr ebyhr merged commit 37adec9 into trinodb:master May 18, 2022
@github-actions github-actions bot added this to the 382 milestone May 18, 2022
@mosabua mosabua mentioned this pull request May 18, 2022
Merged
@polaris6 polaris6 deleted the update-presto-to-trino branch May 19, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@hashhar hashhar Awaiting requested review from hashhar

@wendigo wendigo Awaiting requested review from wendigo

@leveyja leveyja Awaiting requested review from leveyja

Assignees
No one assigned
Labels
cla-signed
Milestone
382
Development

Successfully merging this pull request may close these issues.
2 participants
@polaris6 @ebyhr