Enforce required argument order in aggregation annotation parser #12396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
electrum
approved these changes
May 17, 2022
...trino-main/src/main/java/io/trino/operator/aggregation/AggregationFromAnnotationsParser.java
Outdated
Show resolved
Hide resolved
Input and output aggregation methods require a specific parameter order but this not was being enforces by the annotation parser. Instead this error causes confusing runtime errors. Additionally, it appears that in older versions of Trino alternative parameter orders were allowed, and there was a test for that. This test is invalid and had been adjusted to ensure proper exceptions are thrown.
dain
force-pushed
the
aggregation-annotation-verification
branch
from
83a4d81 to
5dcd8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input and output aggregation methods require a specific parameter order
but this not was being enforces by the annotation parser. Instead
this error causes confusing runtime errors.
Additionally, it appears that in older versions of Trino alternative
parameter orders were allowed, and there was a test for that. This test
is invalid and had been adjusted to ensure proper exceptions are thrown.
NOTE: this does not change any actual behavior and instead simply makes exceptions explicit.
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(X) No release notes entries required.
( ) Release notes entries required with the following suggested text: