Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query cache option in BigQuery #12408

Merged
merged 2 commits into from
May 19, 2022
Merged

Support query cache option in BigQuery #12408

merged 2 commits into from
May 19, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 16, 2022 •
edited
Loading

Description

Support query cache option in BigQuery https://cloud.google.com/bigquery/docs/cached-results

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) Release notes entries required with the following suggested text:

# BigQuery
* Add support for [query results cache](https://cloud.google.com/bigquery/docs/cached-results).
  This can be enabled using the `bigquery.query-results-cache.enabled` config property ({issue}`12408`)

@cla-bot cla-bot bot added the cla-signed label May 16, 2022
@github-actions github-actions bot added the docs label May 16, 2022
@ebyhr ebyhr requested review from wendigo and hashhar May 16, 2022 09:17
@hashhar hashhar requested a review from leveyja May 17, 2022 10:17
leveyja
leveyja approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@leveyja leveyja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/TestBigQueryConnectorTest.java Outdated Show resolved Hide resolved
hashhar
hashhar approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Seems invalidation and whether to use cache or not is handled automatically by the client/bigquery - https://cloud.google.com/bigquery/docs/cached-results#cache-exceptions

@hashhar
Copy link
Member

hashhar commented May 18, 2022

Seems we don't have docs about the session properties though. Needs to be done separately though.

@ebyhr ebyhr force-pushed the ebi/bigquery-query-cache branch from 4b3d24a to 149d755 Compare May 18, 2022 08:54
@ebyhr ebyhr force-pushed the ebi/bigquery-query-cache branch from 149d755 to ec70bc0 Compare May 18, 2022 09:33
@ebyhr ebyhr merged commit a958faa into master May 19, 2022
@ebyhr ebyhr deleted the ebi/bigquery-query-cache branch May 19, 2022 00:43
@github-actions github-actions bot added this to the 382 milestone May 19, 2022
@ebyhr ebyhr mentioned this pull request May 19, 2022
Closed
@mosabua mosabua mentioned this pull request May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leveyja leveyja leveyja approved these changes

@hashhar hashhar hashhar approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed docs
Milestone
382
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @hashhar @leveyja