Rearrange try/catch blocks in HiveMetastoreTableOperations #12420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
added
the
no-release-notes
|
That narrows scope where |
alexjo2144
force-pushed
the
iceberg/code-cleanup
branch
from
c455902 to
cc9f3da
Compare
The only retryable failures in this block are the `replaceTable` call and the CommitFailedException already thrown if the metadata location has been updated. Exceptions thrown by checkState, or because the table does not exist should not retry.
alexjo2144
force-pushed
the
iceberg/code-cleanup
branch
from
cc9f3da to
ccb884d
Compare
|
Sure, updated |
homar
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor code cleanup
Refactoring
Iceberg connector, HMS Catalog
n/a
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: