Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external table in Hive sync partition tests #12448

Merged
merged 1 commit into from
May 20, 2022
Merged

Use external table in Hive sync partition tests #12448

merged 1 commit into from
May 20, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented May 18, 2022 •
edited
Loading

Description

Use external table in Hive sync partition tests

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label May 18, 2022
@ebyhr ebyhr force-pushed the ebi/hive-partition-f23b4bdd87 branch 4 times, most recently from 3e95d32 to 63bffd1 Compare May 19, 2022 05:11
findepi
findepi approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(skimmed)

@findepi findepi requested a review from findinpath May 19, 2022 14:12
@findinpath
Copy link
Contributor

Build is red

2022-05-19 11:14:41 SEVERE: Failure cause:
tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20220519_052940_00544_xwyfg): Target directory for table 'default.test_sync_partition_metadata_add_partition' already exists: hdfs://hadoop-master:9000/user/hive/warehouse/test_sync_partition_metadata_add_partition
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$1.lambda$executeQuery$0(QueryExecutors.java:55)

@ebyhr
Copy link
Member Author

ebyhr commented May 19, 2022 •
edited
Loading

Sorry, this PR isn't ready for review. Let me request after fixing CI failure.

@ebyhr
Use warehouse_directory_path in TestHdfsSyncPartitionMetadata
98b445f 
68ac7c8 changed schema
location. Move setUp and tearDown methods to ABFS because
removing default warhouse directory affects other tests.
@ebyhr ebyhr force-pushed the ebi/hive-partition-f23b4bdd87 branch from 63bffd1 to 98b445f Compare May 20, 2022 03:56
@ebyhr ebyhr marked this pull request as ready for review May 20, 2022 07:59
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label May 20, 2022
@ebyhr ebyhr merged commit 9549957 into master May 20, 2022
@ebyhr ebyhr deleted the ebi/hive-partition-f23b4bdd87 branch May 20, 2022 08:03
@github-actions github-actions bot added this to the 382 milestone May 20, 2022
@mosabua mosabua mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@findinpath findinpath Awaiting requested review from findinpath

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
382
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @findinpath @findepi