Merge three Prometheus integration tests into one #12458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
May 19, 2022
There was a problem hiding this comment.
Please remove
- testRetrieveUpValue (handled in PrometheusServer)
- testMetadata (testDescribeTable is enough)
- testGetTableHandle (unhelpful)
- testGetColumnHandles (testDescribeTable is enough)
- testGetTableMetadata (testDescribeTable is enough)
- testListTables (testShowTables is enough)
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
ebyhr
added
the
no-release-notes
Removed |
|
Also Squash the commits |
ebyhr
approved these changes
May 19, 2022
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
zhaoyim
force-pushed
the
i12492_2
branch
3 times, most recently
from
cd7d734 to
115b766
Compare
ebyhr
reviewed
May 19, 2022
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/PrometheusServer.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
May 19, 2022
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusIntegration.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/PrometheusServer.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
May 20, 2022
plugin/trino-prometheus/src/test/java/io/trino/plugin/prometheus/PrometheusServer.java
Show resolved
Hide resolved
zhaoyim
force-pushed
the
i12492_2
branch
3 times, most recently
from
547ce24 to
9163821
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.