Free task descriptor memory for finished tasks #12478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In execution mode with task retries we need to keep task descriptors which
(among other things) wrap set of input split until matching tasks finishe.
It is needed so we can restart a task in case of a failure.
Previously we kept the descriptor in memory even after task successfully
finished which was wasteful. It could result in crossing descriptor
storage size boundary which resulted in query failures with
EXCEEDED_TASK_DESCRIPTOR_STORAGE_CAPACITY error code.
With this commit we drop task descriptor from storage as soon as we
observe matching task complete succesfully.
improvement
core engine
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: