Remove redundant condition in test #12517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
ebyhr
approved these changes
May 24, 2022
|
CI hit #12300 |
hashhar
reviewed
May 24, 2022
| @@ -2749,7 +2749,7 @@ public void testUpdateRowConcurrently() | |||
| verifyConcurrentUpdateFailurePermissible(trinoException); | |||
| } | |||
| catch (Throwable verifyFailure) { | |||
| if (trinoException != e && verifyFailure != e) { | |||
There was a problem hiding this comment.
Change looks good to me.
Only thing coming in my mind is that trinoException might be equal to e but that implies that the exception has a cycle/self-reference?
e.g.
catch (Exception e) {
RuntimeException trinoException = getTrinoExceptionCause(e);
e.addSuppressed(trinoException);
throw new TrinoException(..., e);
}There was a problem hiding this comment.
it's possible & legit for e == trinoException:
RuntimeException trinoException = getTrinoExceptionCause(e);
simply e may be TrinoException itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.