Time travel engine improvements #12542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
martint,
losipiuk,
rajarshisarkar,
hashhar,
jacob-stein and
findinpath
findinpath
reviewed
May 25, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
May 25, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
jacob-stein
reviewed
May 26, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/time-travel-api
branch
2 times, most recently
from
8c2ad46 to
2c8254b
Compare
findinpath
approved these changes
Jun 7, 2022
|
previously CI #12726 |
martint
approved these changes
Jun 7, 2022
|
Rebasing after #10258 merged. |
findepi
force-pushed
the
findepi/time-travel-api
branch
from
ec48889 to
1626d64
Compare
|
CI #12726 |
adding small change to address #10258 (comment) |
findepi
force-pushed
the
findepi/time-travel-api
branch
2 times, most recently
from
e88535a to
50b12f2
Compare
|
previous CI #12726 |
losipiuk
approved these changes
Jun 9, 2022
|
conflict, rebasing |
findepi
force-pushed
the
findepi/time-travel-api
branch
2 times, most recently
from
a4766ac to
c026a60
Compare
findepi
force-pushed
the
findepi/time-travel-api
branch
3 times, most recently
from
bffdacd to
23580da
Compare
|
Build is green again. There were some changes (#12542 (comment)). @losipiuk or @martint PTAL. |
losipiuk
reviewed
Jun 13, 2022
| * some weird way, serving as a smoke test for versioning. The purpose of the test is to validate the connector does proper validation. | ||
| */ | ||
| @Test | ||
| public void testTrySelectTableVersion() |
There was a problem hiding this comment.
I am not sure I get the intent here. Is there expectation from specific connector to provide more verbose version of this test which actually verifies specifically which query should fail and which should not?
There was a problem hiding this comment.
My expectation is that a connector supporting time travel will have its own test covering it.
Here, we only cover cases and verify they don't end up with some NPE, IAE, ISE or something.
findinpath
reviewed
Jun 13, 2022
core/trino-spi/src/test/java/io/trino/spi/TestSpiBackwardCompatibility.java
Show resolved
Hide resolved
Move versioned `getTableHandle` under the plain one.
When querying a table `FOR VERSION` there are these potential failure scenarios 1. The table doesn't exist. 2. The connector doesn't support versioning at all. 3. The connector does not support given version type is not supported (e.g. supported versions are `bigint` (as in Iceberg) but user. provided a `varchar`) 4. The version type is fine, but requested version doesn't exist (e.g. bad Iceberg snapshot id). Previously, when connector doesn't support versioning *and* table doesn't exist, the message would indicate unsupported versioning, while informing about table not being found is more appropriate. To further differentiate between failure scenarios 2, 3 and 4, the `ConnectorMetadata.isValidTableVersion` is removed. Instead, we rely on `ConnectorMetadata.getTableHandle` to do proper checks (is versioning supported? is version type supported? is version valid?). A sane implementation will do such checks anyway, so this simplifies the SPI.
If a connector implements table versioning, it's going to implement `getTableHandle` that accepts optional version specification. It shouldn't need to still implement the `getTableHandle` without versioning specification.
findepi
force-pushed
the
findepi/time-travel-api
branch
from
23580da to
6b62b43
Compare
|
(rebased to resolve conflict) |
|
Do we want release notes for this? |
findepi
added
the
no-release-notes
|
Test is added in scope of #12831 |
findepi
removed
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.