Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-aggregate repeated case aggregations #12548

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Pre-aggregate repeated case aggregations #12548

merged 1 commit into from
Jul 19, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented May 25, 2022 •
edited by kasiafi
Loading

Rule that transforms:

  • Aggregation[key]: sum(aggr1), sum(aggr2), ..., sum(aggrN)
    • Project:
      aggr1 = CASE WHEN col=1 THEN expr ELSE 0
      aggr2 = CASE WHEN col=2 THEN expr ELSE 0
      ...
      aggrN = CASE WHEN col=N THEN expr ELSE 0
      • source

into:

  • Aggregation[key]: sum(aggr1), sum(aggr2), ..., sum(aggrN)
    • Project:
      aggr1 = CASE WHEN col=1 THEN pre_aggregate ELSE 0
      aggr2 = CASE WHEN col=2 THEN pre_aggregate ELSE 0
      ..
      aggrN = CASE WHEN col=N THEN pre_aggregate ELSE 0
      • Aggregation[key, col]: pre_aggregate = sum(expr)
        • source

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@sopel39 sopel39 requested a review from findepi May 25, 2022 15:49
@cla-bot cla-bot bot added the cla-signed label May 25, 2022
@sopel39 sopel39 marked this pull request as ready for review May 25, 2022 15:50
findepi
findepi reviewed May 26, 2022
View reviewed changes
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Outdated Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Outdated Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Outdated Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
@findepi findepi requested a review from kasiafi May 26, 2022 07:33
@sopel39 sopel39 force-pushed the ks/pre-aggregate branch from ccfe9c3 to 6516b41 Compare May 26, 2022 12:31
@sopel39 sopel39 requested a review from findepi May 26, 2022 12:31
@findepi findepi requested review from kasiafi and martint and removed request for kasiafi June 7, 2022 15:49
@sopel39 sopel39 requested a review from kasiafi June 23, 2022 11:33
kasiafi
kasiafi approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@kasiafi kasiafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Show resolved Hide resolved
...ino-main/src/main/java/io/trino/sql/planner/iterative/rule/PreAggregateCaseAggregations.java Outdated Show resolved Hide resolved
@sopel39
Pre-aggregate repeated case aggregations
d8e7a1f 
Rule that transforms:
- Aggregation[key]: sum(aggr1), sum(aggr2), ..., sum(aggrN)
  - Project:
       aggr1 = CASE WHEN col=1 THEN expr ELSE 0
       aggr2 = CASE WHEN col=2 THEN expr ELSE 0
       ...
       aggrN = CASE WHEN col=2 THEN expr ELSE 0
     - source

 into:

- Aggregation[key]: sum(aggr1), sum(aggr2), ..., sum(aggrN)
   - Project:
       aggr1 = CASE WHEN col=1 THEN pre_aggregate ELSE 0
       aggr2 = CASE WHEN col=2 THEN pre_aggregate ELSE 0
       ..
       aggrN = CASE WHEN col=2 THEN pre_aggregate ELSE 0
     - Aggregation[key, col]: pre_aggregate = sum(expr)
       - source
@sopel39 sopel39 force-pushed the ks/pre-aggregate branch from 6516b41 to d8e7a1f Compare July 18, 2022 14:52
@sopel39 sopel39 merged commit 345652e into trinodb:master Jul 19, 2022
@sopel39 sopel39 deleted the ks/pre-aggregate branch July 19, 2022 09:39
@github-actions github-actions bot added this to the 391 milestone Jul 19, 2022
@sopel39 sopel39 mentioned this pull request Jul 19, 2022
Closed
@colebow colebow mentioned this pull request Jul 19, 2022
Merged
@arhimondr arhimondr mentioned this pull request Jul 20, 2022
Closed
@sopel39 sopel39 mentioned this pull request Jul 21, 2022
Merged
@weiatwork weiatwork mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasiafi kasiafi kasiafi approved these changes

@findepi findepi Awaiting requested review from findepi

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed
Milestone
391
Development

Successfully merging this pull request may close these issues.
4 participants
@sopel39 @martint @findepi @kasiafi