Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maven wrapper to 3.1.1 #12661

Closed
wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 2, 2022

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jun 2, 2022
@wendigo wendigo requested review from nineinchnick and findepi June 2, 2022 12:18
mvnw.cmd Outdated Show resolved Hide resolved
@findepi findepi removed their request for review August 2, 2022 18:33
@wendigo wendigo force-pushed the serafin/mvn-wrapper-3.1.1 branch from c087abd to a63919f Compare February 20, 2023 15:02
@wendigo
Copy link
Contributor Author

wendigo commented Feb 20, 2023

I've dropped mvnw script for windows. @nineinchnick @martint ptal

# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the license from here.

# specific language governing permissions and limitations
# under the License.
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need two urls now?

@wendigo wendigo closed this Apr 4, 2023
@wendigo wendigo deleted the serafin/mvn-wrapper-3.1.1 branch April 4, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants