Set DB_CLOSE_DELAY for Raptor H2 #12777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Jun 10, 2022
| @@ -85,7 +86,7 @@ public void configure(Binder binder) | |||
| @ForMetadata | |||
| public static ConnectionFactory createConnectionFactory(H2DatabaseConfig config) | |||
| { | |||
| String url = "jdbc:h2:" + config.getFilename(); | |||
| String url = format("jdbc:h2:%s;DB_CLOSE_DELAY=-1", config.getFilename()); | |||
There was a problem hiding this comment.
Worth documenting why DB_CLOSE_DELAY matters?
There was a problem hiding this comment.
per h2 docs, DB_CLOSE_DELAY=-1 will keep database around for longer (which is probably desireable in the tests)
i expect this will address some H2 related failures that i observed in my stress test #12730
will this also prevent OOM? why?
intuitively DB_CLOSE_DELAY=-1 increases memory usage, not decreases.
There was a problem hiding this comment.
I have no idea. It's been there forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fix. Restores previous
dbpoolbehavior.Related issues, pull requests, and links
Fixes #12726
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.