Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining the Redis types in doc #12884

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Refining the Redis types in doc #12884

merged 1 commit into from
Jun 17, 2022

Conversation

polaris6
Copy link
Member

@polaris6 polaris6 commented Jun 17, 2022 •
edited
Loading

Description

Currently, the keyDataType can only be STRING and ZSET , the valueDataType can only be STRING and HASH .

Documentation

(✓) Sufficient documentation is included in this PR.

Release notes

(✓) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2022
@github-actions github-actions bot added the docs label Jun 17, 2022
@polaris6 polaris6 requested a review from ebyhr June 17, 2022 03:11
@polaris6
Copy link
Member Author

Hi @ebyhr, I think it might be more appropriate to call string column type here. I think there is no table type, the key and value have their own type.
#12881 (comment)

@ebyhr
Copy link
Member

ebyhr commented Jun 17, 2022

"string column type" is misleading. Most people will think about varchar or char types from the keyword. I will suggest a new entry later.

@polaris6
Copy link
Member Author

Yes I agree with you.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Jun 17, 2022
@ebyhr ebyhr merged commit a9cddc5 into trinodb:master Jun 17, 2022
@github-actions github-actions bot added this to the 387 milestone Jun 17, 2022
@polaris6 polaris6 deleted the add_redis_type_doc branch June 17, 2022 03:53
@ebyhr
Copy link
Member

ebyhr commented Jun 17, 2022

Merged, thanks!

@colebow colebow mentioned this pull request Jun 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Milestone
387
Development

Successfully merging this pull request may close these issues.
2 participants
@polaris6 @ebyhr