-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement testCreateTable and testDropTable in Kudu connector test #12899
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
Just emailed the signed CLA. Will the check automatically pass when the document is received? |
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
2 similar comments
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash commits into one. You can update the commit title as "Implement testCreateTable and testDropTable in Kudu connector test".
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#git-merge-strategy
fix #11815
GitHub automatically closes a linked issue if you use "fix {number}". I modified the description as we don't want to close it.
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
41f398f
to
7ff3b77
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
@ebyhr Got it :) Just squashed and force-pushed the commit. Still have to wait for the CLA, though.. |
Could you fix checkstyle failure? https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#code-style
|
@ebyhr Sorry, I've been having trouble running the style check locally.. |
7ff3b77
to
58235d3
Compare
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
Just fixed the checkstyle error, stashed and pushed the commit :) |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@ebyhr CLA is done now .. I am not sure if the test failure is a false alarm .. please proceed to review or merge or whatever appropriate as next step. Thanks |
Merged, thanks! |
Description
An improvement in testing.
Connector tests.
Improved some tests that shouldn't change any behavior.
Related issues, pull requests, and links
A series of PRs will be created to implement #11815. This is the first one.
There are 14 tests to fix in total, this PR fixes the first 2.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.