Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement concurrent tests in Kudu #12995

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Conversation

chen-ni
Copy link
Contributor

@chen-ni chen-ni commented Jun 27, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

An improvement in testing.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Connector tests.

How would you describe this change to a non-technical end-user or system administrator?

Improved some tests that shouldn't change any behavior.

Related issues, pull requests, and links

This is the fourth and last one of a series of PRs to fix #11815. It fixes the 3 remaining tests.

It was part of #12952 but was split into a separate PR.

testReadMetadataWithRelationsConcurrentModifications may result in a test failure described in #12974.

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jun 27, 2022
@chen-ni chen-ni force-pushed the issue-11815-part-4 branch 2 times, most recently from 62eed28 to 4a61c24 Compare July 1, 2022 08:52
@chen-ni chen-ni marked this pull request as ready for review July 1, 2022 11:27
@chen-ni chen-ni requested a review from ebyhr July 1, 2022 12:43
@ebyhr
Copy link
Member

ebyhr commented Jul 1, 2022

@chen-ni Please rebase on upstream to resolve conflicts.

@chen-ni chen-ni force-pushed the issue-11815-part-4 branch from 4a61c24 to a8f09f2 Compare July 1, 2022 14:02
@chen-ni
Copy link
Contributor Author

chen-ni commented Jul 1, 2022

@ebyhr Done :)

@chen-ni chen-ni force-pushed the issue-11815-part-4 branch from a8f09f2 to aa73955 Compare July 4, 2022 01:21
@chen-ni chen-ni requested a review from ebyhr July 4, 2022 02:47
@ebyhr ebyhr merged commit 844f91b into trinodb:master Jul 4, 2022
@ebyhr
Copy link
Member

ebyhr commented Jul 4, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 389 milestone Jul 4, 2022
@chen-ni chen-ni deleted the issue-11815-part-4 branch July 4, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Revisit all TODO in AbstractKuduConnectorTest
2 participants