Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MethodHandleUtil #13245

Merged
merged 4 commits into from
Aug 9, 2022
Merged

Deprecate MethodHandleUtil #13245

merged 4 commits into from
Aug 9, 2022

Conversation

electrum
Copy link
Member

@electrum electrum commented Jul 20, 2022 •
edited
Loading

Description

Is this change a fix, improvement, new feature, refactoring, or other?

SPI cleanup

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

SPI interfaces

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# SPI changes
* Deprecate `io.trino.spi.block.MethodHandleUtil`. ({issue}`13245`)

@cla-bot cla-bot bot added the cla-signed label Jul 20, 2022
@electrum electrum requested review from dain and martint July 20, 2022 07:35
@electrum electrum changed the title Methodhandleutil Deprecate MethodHandleUtil Jul 20, 2022
@electrum electrum force-pushed the methodhandleutil branch 2 times, most recently from b9f84a1 to d421371 Compare July 25, 2022 19:06
dain
dain approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a ban on the import of this class in Trino so it doesn't creep back in

@electrum electrum merged commit bcfe05f into trinodb:master Aug 9, 2022
@electrum electrum deleted the methodhandleutil branch August 9, 2022 04:29
@github-actions github-actions bot added this to the 393 milestone Aug 9, 2022
@colebow colebow mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain dain approved these changes

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed
Milestone
393
Development

Successfully merging this pull request may close these issues.
2 participants
@electrum @dain