Move constant to relevant scope

[lukasz-walkiewicz]

Description

Move constant to relevant scope

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[martint]

Improvement

What problem is this solving? What's the impact of loading vs not loading those classes? Presumably, and unless there are resources being initialized in a static context, there should be no effect from loading the classes eagerly.

[lukasz-walkiewicz]

Thanks @martint for taking a look.
This fix is to defer loading Rubix classes and ensure that Trino loads them only when hive.cache.enabled=true. CachingPrestoDistributedFileSystem was being loaded even with caching disabled just because RubixModule is registed as conditional module.

[lukasz-walkiewicz]

The general idea here is to be able to safely remove Rubix dependency if caching is not being used. Rubix is marked by security scanners as vulnarable to https://nvd.nist.gov/vuln/detail/CVE-2022-25647 due to it's dependency on gson. No updates that could fix that at the moment.

[raunaqmorarka]

@lukasz-walkiewicz do you have confirmation that a build with this change will pass security scan ?

[lukasz-walkiewicz]

No, I don't but I can confirm that with this change you can safely remove Rubix jar from hive plugin directory so I think it'll pass the scan.

[kokosing]

Please rename commit title and PR title and description to Move constant to relevant scope.

[martint]

This change may have the side effect of delaying loading of those classes, but that cannot be guaranteed now or ever, so it shouldn't be the main purpose of this change. It's fine as a code cleanup, though.

[lukasz-walkiewicz]

Updated commit message, thanks for the review.

[kokosing]

Please do the same with PR title and description.