Handle empty Iceberg tables while executing procedures #13582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
approved these changes
Aug 9, 2022
ebyhr
reviewed
Aug 9, 2022
| @@ -1194,6 +1194,10 @@ public void executeRemoveOrphanFiles(ConnectorSession session, IcebergTableExecu | |||
| IcebergConfig.REMOVE_ORPHAN_FILES_MIN_RETENTION, | |||
| IcebergSessionProperties.REMOVE_ORPHAN_FILES_MIN_RETENTION); | |||
|
|
|||
| if (table.currentSnapshot() == null) { | |||
There was a problem hiding this comment.
remove_orphan_files procedure still fails on file metastore due to lack of /data directory. Could you leave a TODO comment?
There was a problem hiding this comment.
Why would it be specific to the TESTING_FILE_METASTORE?
There was a problem hiding this comment.
Do you have a stack trace?
There was a problem hiding this comment.
The query and stacktrace:
trino:tpch> CREATE TABLE test (c1 int);
trino:tpch> ALTER TABLE test EXECUTE remove_orphan_files(retention_threshold => '7d');
Query 20220810_221426_00026_hjz7i failed: Failed accessing data for table: tpch.test
io.trino.spi.TrinoException: Failed accessing data for table: tpch.test
at io.trino.plugin.iceberg.IcebergMetadata.scanAndDeleteInvalidFiles(IcebergMetadata.java:1255)
at io.trino.plugin.iceberg.IcebergMetadata.removeOrphanFiles(IcebergMetadata.java:1215)
at io.trino.plugin.iceberg.IcebergMetadata.executeRemoveOrphanFiles(IcebergMetadata.java:1198)
at io.trino.plugin.iceberg.IcebergMetadata.executeTableExecute(IcebergMetadata.java:1116)
at io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata.executeTableExecute(ClassLoaderSafeConnectorMetadata.java:216)
at io.trino.metadata.MetadataManager.executeTableExecute(MetadataManager.java:345)
at io.trino.operator.SimpleTableExecuteOperator.getOutput(SimpleTableExecuteOperator.java:128)
at io.trino.operator.Driver.processInternal(Driver.java:410)
at io.trino.operator.Driver.lambda$process$10(Driver.java:313)
at io.trino.operator.Driver.tryWithLock(Driver.java:698)
at io.trino.operator.Driver.process(Driver.java:305)
at io.trino.operator.Driver.processForDuration(Driver.java:276)
at io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:740)
at io.trino.execution.executor.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:164)
at io.trino.execution.executor.TaskExecutor$TaskRunner.run(TaskExecutor.java:490)
at io.trino.$gen.Trino_testversion____20220810_221353_71.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.io.FileNotFoundException: File /var/folders/8s/dkvf18z55lj_9yxhy1n54sph0000gn/T/TrinoTest1711210759979949419/iceberg_data/tpch/test-b3dc0ba83a6542229b672271f21d09eb/data does not exist
at org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:489)
at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1868)
at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1910)
at org.apache.hadoop.fs.FileSystem$4.<init>(FileSystem.java:2072)
at org.apache.hadoop.fs.FileSystem.listLocatedStatus(FileSystem.java:2071)
at org.apache.hadoop.fs.ChecksumFileSystem.listLocatedStatus(ChecksumFileSystem.java:700)
at org.apache.hadoop.fs.FileSystem$5.<init>(FileSystem.java:2183)
at org.apache.hadoop.fs.FileSystem.listFiles(FileSystem.java:2180)
at io.trino.plugin.hive.fs.TrinoFileSystemCache$FileSystemWrapper.listFiles(TrinoFileSystemCache.java:386)
at io.trino.plugin.iceberg.IcebergMetadata.scanAndDeleteInvalidFiles(IcebergMetadata.java:1239)
... 18 more
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Show resolved
Hide resolved
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Aug 10, 2022
If a table was just created it may not contain any snapshots. Procedures run on tables that do not contain any snapshots can safely do nothing.
alexjo2144
force-pushed
the
iceberg/optimize-empty-tables
branch
from
7594677 to
9dee7a0
Compare
|
All set, thanks for the reviews |
|
@alexjo2144 can you please suggest RN wording? |
|
CI hit #13556 |
|
@findepi added a suggestion to the PR description |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a table was just created it may not contain any snapshots. Procedures run on tables that do not contain any snapshots can safely do nothing.
Fix
Iceberg connector
Prevent query failure in the edge case where a table is empty and has no history.
Related issues, pull requests, and links
Related to: #13576
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: