Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code cleanup #13583

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Minor code cleanup #13583

merged 3 commits into from
Aug 10, 2022

Conversation

tangjiangling
Copy link
Member

@tangjiangling tangjiangling commented Aug 10, 2022

  • Remove redundant cast from SmallintType and TinyintType
  • Fix grammar and typo in JdbcPageSink

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Aug 10, 2022
@tangjiangling tangjiangling requested review from hashhar and ebyhr August 10, 2022 00:24
@tangjiangling tangjiangling added the no-release-notes This pull request does not require release notes entry label Aug 10, 2022
@tangjiangling
Copy link
Member Author

AC

@ebyhr
Copy link
Member

ebyhr commented Aug 10, 2022

CI hit #13556

@ebyhr ebyhr merged commit fc83eb3 into trinodb:master Aug 10, 2022
@ebyhr
Copy link
Member

ebyhr commented Aug 10, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 393 milestone Aug 10, 2022
@tangjiangling tangjiangling deleted the minor-code-cleanup branch August 10, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants