Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify SourcePartitionedScheduler #13650

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Aug 12, 2022

After removal of grouped execution SourcePartitionedScheduler
can be futher simplified.

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Contributor

@arhimondr arhimondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % questions

After removal of grouped execution SourcePartitionedScheduler
can be futher simplified.
@sopel39 sopel39 merged commit f45ff16 into trinodb:master Aug 17, 2022
@sopel39 sopel39 deleted the ks/simplify branch August 17, 2022 11:00
@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
@colebow colebow added the no-release-notes This pull request does not require release notes entry label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants