Fix failing testInsertIntoNotNullColumn in SingleStore #13677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
commented
Aug 15, 2022
| @@ -223,6 +223,31 @@ public void testSingleStoreTinyint() | |||
| assertUpdate("DROP TABLE mysql_test_tinyint1"); | |||
| } | |||
|
|
|||
| // Overridden because the method from BaseConnectorTest fails on one of the assertions, see TODO below | |||
| @Override | |||
| public void testInsertIntoNotNullColumn() | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
hmm how come it didn't fail when I added it ..
There was a problem hiding this comment.
SingleStore tests don't run when the PR comes from forked repository because it requires a license.
https://github.com/trinodb/trino/blob/master/plugin/trino-singlestore/src/test/java/io/trino/plugin/singlestore/TestingSingleStoreServer.java#L31
There was a problem hiding this comment.
oh right, is SingleStore the only one that failed because of my change?
There was a problem hiding this comment.
I believe so. This master job https://github.com/trinodb/trino/runs/7822744342 was green except for test (plugin/trino-singlestore) yesterday.
homar
approved these changes
Aug 15, 2022
hashhar
approved these changes
Aug 16, 2022
hashhar
added
the
no-release-notes
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failing
testInsertIntoNotNullColumnin SingleStore. The test has been failing on master.https://github.com/trinodb/trino/runs/7832907169
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.