Remove empty UPDATE
#13755
Merged
Remove empty UPDATE
#13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
requested review from
kokosing,
martint and
losipiuk
and removed request for
kokosing
findinpath
commented
Aug 19, 2022
| public class TestRemoveEmptyUpdate | ||
| extends BaseRuleTest | ||
| { | ||
| @Test |
There was a problem hiding this comment.
I'm inexperienced in the query planning area of Trino so I'd very much benefit of some hints regarding to improve/extend the tests for this fix.
findinpath
changed the title
UPDATEUPDATE with VALUES node containing 0 value
findinpath
changed the title
UPDATE with VALUES node containing 0 valueUPDATE
Replace the `UPDATE` plan node with an empty `VALUES` node when the predicate is optimized to `false`.
findinpath
force-pushed
the
update-where-false
branch
from
0806c6c to
d85660b
Compare
findepi
approved these changes
Aug 22, 2022
| .addAll(RemoveEmptyDeleteRuleSet.rules()) | ||
| .add(new RemoveEmptyUpdate()) |
There was a problem hiding this comment.
for Delete we have a rule set (since we match empty delete with and without an exchange).
wonder whether this is some left over (or otherwise: why don't we need same for Update?)
losipiuk
approved these changes
Aug 23, 2022
RN are meant to be understood by users. I will reformulate this -- #13723 (comment) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the
UPDATEplan node with an emptyVALUESnode when the predicate is optimized tofalse.Fix
Core query engine
Support queries like the following:
Related issues, pull requests, and links
Fixes #12422
This PR takes inspiration from the commit 02be06c which was dealing with empty
DELETEplan nodes.Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: