Improve type mapping documentation for Druid connector #13776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jhlodin
reviewed
Aug 22, 2022
hashhar
reviewed
Aug 24, 2022
jhlodin
reviewed
Aug 25, 2022
jhlodin
reviewed
Aug 25, 2022
hashhar
reviewed
Aug 30, 2022
hashhar
reviewed
Aug 30, 2022
tlblessing
force-pushed
the
tb/druid-type-mapping
branch
4 times, most recently
from
3fc33d5 to
43584de
Compare
|
@hashhar just one remaining question for you here #13776 (comment). Thank you Ashhar, @ebyhr , and @jhlodin for your guidance and reviews. Incorporated comments, squashed commits , and ready for another review. |
jhlodin
reviewed
Aug 31, 2022
tlblessing
force-pushed
the
tb/druid-type-mapping
branch
2 times, most recently
from
6f2f8a8 to
b682b0c
Compare
jhlodin
approved these changes
Sep 2, 2022
mosabua
approved these changes
Sep 6, 2022
tlblessing
force-pushed
the
tb/druid-type-mapping
branch
from
b682b0c to
2cb5873
Compare
|
This PR is now ready to merge. |
hashhar
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve type mapping documentation for Druid connector. Added a type mapping table based on Druid documentation.
Docs improvement
Connector type mapping documentation
Added a data type mapping section
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: