Add type mapping section to Singlestore connector #13801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Need help verifying if type mapping is correct. |
ebyhr
reviewed
Aug 23, 2022
Jessie212
force-pushed
the
jt/singlestore-type-mapping
branch
from
77fcbd5 to
7096b93
Compare
|
@ebyhr I've included all Trino data types. It's easier to request certain data types be removed rather than have you point out what's missing. |
|
Could you take a look at |
Jessie212
force-pushed
the
jt/singlestore-type-mapping
branch
from
7096b93 to
a6029fb
Compare
|
@ebyhr Thanks for referring me to the code. I wouldn't have know to look for |
ebyhr
force-pushed
the
jt/singlestore-type-mapping
branch
from
a6029fb to
03ea465
Compare
ebyhr
approved these changes
Sep 5, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement.
Changes made to documentation.
Add type mapping section to Singlestore connector
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: