Support snapshot queries on Iceberg system tables - custom IcebergSystemTableHandle extends SystemTableHandle #13854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
changed the title
findinpath
force-pushed
the
iceberg-metadata-tables-versioned-queries
branch
from
f5780f3 to
7d40fd2
Compare
Add the ability of querying Iceberg system tables by using time travel queries either by snapshot or by timestamp. Previously there were supported versioned queries on system tables because the snapshot id could be encoded within the table name: ``` SELECT * FROM table1$files@1242141 ``` The syntax mentioned previously is now deprecated and replaced by a richer syntax: ``` SELECT * FROM table1$files FOR VERSION AS OF 1242141 SELECT * FROM table1$files FOR TIMESTAMP AS OF TIMESTAMP '2022-01-01' ``` `SystemTableHandle` has been transformed to an interface and was moved to `trino-spi` for being able to add a custom implementation for this interface for the Iceberg connector which supports time travel on the metadata tables.
findinpath
force-pushed
the
iceberg-metadata-tables-versioned-queries
branch
from
7d40fd2 to
6f40f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability of querying Iceberg system tables by using
time travel queries either by snapshot or by timestamp.
Previously there were supported versioned queries on system
tables because the snapshot id could be encoded within the
table name:
The syntax mentioned previously is now deprecated and
replaced by a richer syntax:
SystemTableHandlehas been transformed to an interfaceand was moved to
trino-spifor being able to add acustom implementation for this interface for the Iceberg
connector which supports time travel on the metadata
tables.
Bugfix
Iceberg connector
The metadata tables exposed by the Iceberg connector for its tables should support snapshot/versioned queries in the same fashion as the Iceberg tables.
Related issues, pull requests, and links
Fixes #12736
This PR offers a different approach to #13497 by extending SystemTableHandle for Iceberg time travel queries needs.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
() No release notes entries required.
(x) Release notes entries required with the following suggested text: