Improve type mapping documentation for BigQuery connector #13870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 26, 2022
jhlodin
requested review from
ebyhr
and removed request for
electrum and
davidrabinowitz
tlblessing
force-pushed
the
tb/bigquery-type-mapping
branch
from
e393556 to
5e1865a
Compare
ebyhr
force-pushed
the
tb/bigquery-type-mapping
branch
from
5e1865a to
77696d6
Compare
ebyhr
approved these changes
Aug 31, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve type mapping documentation for BigQuery connector.
Improvement to BigQuery connector documentation
Added data type mapping for write direction (Trino --> BigQuery); reformatted table for better wrapping; added boilerplate headings and verbiage for consistency.
Question for SMEs: I wasn't sure about the new write table. To avoid 1:m mapping in write direction, I chose
BIGNUMERICforDECIMAL(P,S)instead ofNUMERIC. I was not sure which one to choose forVARCHAR(STRINGorGEOGRAPHY), so left them both. Please advise.Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: