Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify connector support for SQL MERGE #13976

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Sep 2, 2022

Description

MERGE support may be misleading, since the source table can come from any catalog. Update documentation to be more explicit about SQL MERGE support.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Be more clear about what it means when a connector supports or does not support MERGE

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link
Member

@djsstarburst djsstarburst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/src/main/sphinx/sql/merge.rst Outdated Show resolved Hide resolved
@jhlodin jhlodin force-pushed the jl/sql-merge-support branch from 56e8d2f to 7356181 Compare September 6, 2022 17:05
@hashhar hashhar merged commit 93881a8 into trinodb:master Sep 6, 2022
@github-actions github-actions bot added this to the 395 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants