Update dev guide for benchmarks #13988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelWeezardo
force-pushed
the
michal/benchmarks_dev_guide
branch
from
a11d905 to
6000bc4
Compare
nineinchnick
reviewed
Sep 5, 2022
testing/trino-benchto-benchmarks/generate_schemas/generate-tpcds.py
Outdated
Show resolved
Hide resolved
nineinchnick
reviewed
Sep 5, 2022
testing/trino-benchto-benchmarks/generate_schemas/generate-tpcds.py
Outdated
Show resolved
Hide resolved
MiguelWeezardo
force-pushed
the
michal/benchmarks_dev_guide
branch
2 times, most recently
from
ebc431f to
940ee37
Compare
findepi
reviewed
Sep 9, 2022
sopel39
reviewed
Sep 21, 2022
| @@ -1,53 +1,63 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
did you use the tool to generate schemas manually as a test?
There was a problem hiding this comment.
Thanks, running this unveiled a trivial bug. It took a while to setup Trino with a fully functional Hive connector, but I finally found a product test environment with both hive and tpcds.
MiguelWeezardo
force-pushed
the
michal/benchmarks_dev_guide
branch
3 times, most recently
from
2ad53fd to
578afa7
Compare
MiguelWeezardo
force-pushed
the
michal/benchmarks_dev_guide
branch
from
5186585 to
95fda96
Compare
Sometimes we want to run benchmarks on a small dataset. We want to be able to choose the scale factors for TPC-H and TPC-DS. This change keeps the original defaults while allowing for scale factor and format overrides.
MiguelWeezardo
force-pushed
the
michal/benchmarks_dev_guide
branch
from
95fda96 to
78c5ef4
Compare
nineinchnick
approved these changes
Oct 26, 2022
|
Failed due: #14618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: