Smoke test varchar value with backslash #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
|
CI #13946 and apparent maven central problems |
|
CI #14141 |
hashhar
reviewed
Sep 16, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Show resolved
Hide resolved
hashhar
reviewed
Sep 16, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/smoke-test-varchar-value-with-backslash-1020c6
branch
from
913b027 to
3e5d84a
Compare
This is testing correctness, regardless of whether the pushdown happens. This covers a case where pushdown cannot happen with a `TupleDomain`, but can be achieved via `ConnectorExpression`.
findepi
force-pushed
the
findepi/smoke-test-varchar-value-with-backslash-1020c6
branch
from
3e5d84a to
cca820a
Compare
findepi
deleted the
findepi/smoke-test-varchar-value-with-backslash-1020c6
branch
|
@findepi This seems to fail for BigQuery on master. Can you PTAL? |
|
Actually -- #7869 uses backslash to escape apostrophes, so we knew backslashes are meaningful and they themselves require escaping ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.