Make PartitionedOutputOperator.finish() idempotent #14168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Sep 16, 2022
lukasz-stec
approved these changes
Sep 17, 2022
| @@ -99,7 +99,9 @@ public boolean isEmpty() | |||
| public Page build() | |||
| { | |||
| if (channelAppenders.length == 0) { | |||
There was a problem hiding this comment.
It would be good to have a test for this case (I can add it in a separate PR). Do you know what kind of query has zero-column partitioning?
There was a problem hiding this comment.
It would be good to have a test for this case (I can add it in a separate PR). Do you know what kind of query has zero-column partitioning?
I observed that with queries like this one:
SELECT o1.orderkey FROM orders o1 RIGHT JOIN (SELECT * FROM orders LIMIT 10) o2 ON true ORDER BY o1.orderkey LIMIT 20
where you are joining two tables, where neither join condition, nor output depend on any column from one of the tables.
As for the testing, it is problematic as I only observed problem when POO.finish() was called twice. And this does not happen often.
The PartitionedOutputOperator.finish() was not idempotent in the case when only position counter was tracked in PositionsAppenderPageBuilder. This could result in wrong query results.
losipiuk
force-pushed
the
lo/fix-part-out-op
branch
from
606f9f4 to
48bb798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PartitionedOutputOperator.finish() was not idempotent in the case when only position counter was tracked in
PositionsAppenderPageBuilder. This could result in wrong query results.
Description
Non-technical explanation
Release notes
( ) This is not user-visible and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: