Support ANALYZE stats composed of expressions #14222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/arbitrary-stats-composable
branch
from
51d1904 to
0c07bc8
Compare
findepi
force-pushed
the
findepi/arbitrary-stats-composable
branch
from
0c07bc8 to
ef71f43
Compare
findepi
force-pushed
the
findepi/arbitrary-stats-composable
branch
from
ef71f43 to
1d4f9ee
Compare
Reduce code noise by moving Symbol -> SymbolReference converstion to the construction method.
This allows a connector to compose statistics collection from an aggregation function and a projection, reducing need for specialized aggregation functions just for stats collection. For example, `$max_data_size_for_stats` and `$sum_data_size_for_stats` can now be decomposed as a simple scalar plus either max or sum aggregation.
findepi
force-pushed
the
findepi/arbitrary-stats-composable
branch
from
1d4f9ee to
f27510b
Compare
|
I assume this is still in progress @findepi ... |
|
currently not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connector may ask engine to collect anything defined by
ColumnStatisticTypeSPI enum. This is convenient, but sometimes a connector needs to provide its own way of calculating statistics.For example, Iceberg statistics include
This has two components which are not supported today
This PR addresses the second limitation, building on top of #14220