Add link to Databricks type support in Delta Lake connector docs #14506
Conversation
| @@ -294,6 +294,10 @@ writing data. Data types may not map the same way in both directions between | |||
| Trino and the data source. Refer to the following sections for type mapping in | |||
| each direction. | |||
|
|
|||
| See the `Databricks data types documentation | |||
| <https://docs.databricks.com/spark/latest/spark-sql/language-manual/sql-ref-datatypes.html>`_ | |||
| for more information about supported types. | |||
There was a problem hiding this comment.
The databaricks docs won't know which types are supported by Trino
There was a problem hiding this comment.
about available data types in Delta Lake.
There was a problem hiding this comment.
the paragraphs says "supported" and doesn't indicate it's not about types supported by something else than Trino
There was a problem hiding this comment.
Would "..about types supported by the Delta Lake connector" be specific enough?
There was a problem hiding this comment.
Actually I prefer Manfred's suggestion of "...for more information about supported data types in Delta Lake" since it's not about Trino, this connector, or any other Trino-specific component.
There was a problem hiding this comment.
If I can nit-pick a little more, could be even more clear that we're talking about the Delta Lake format and not the connector:
"for more information about supported data types in the Delta Lake table format specification."
Either way, this is not the right link. I think you want: https://github.com/delta-io/delta/blob/master/PROTOCOL.md#primitive-types
The Databricks link includes all types that are in the SparkSQL language but not all of them are supported in DL
There was a problem hiding this comment.
Reworded and updated the link to point to the Delta protocol specification.
jhlodin
force-pushed
the
jl/delta-databricks-types
branch
from
2ccc693 to
0aa2567
Compare
|
CI #14618 |
|
CI #14618 (second time) |
Description
The list of supported types in the Delta Lake connector is directly affected by what's supported in the Delta protocol. This PR links out to the Delta Transaction Log protocol's specification for more information about data type support.
Non-technical explanation
Provide link out to the Delta protocol documentation for more information about supported types in Delta Lake.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: