Invalidate table handle cache when column changed #14762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
approved these changes
Oct 26, 2022
|
CI is red |
ssheikin
force-pushed
the
ssheikin/61/oss/table_handle_jdbc_client_caching
branch
from
bb5ee88 to
eda2b10
Compare
Table handle contains column handles. When column is changed, data in cache for table handles is stale. Test TableHandles cache invalidation on columns change.
ssheikin
force-pushed
the
ssheikin/61/oss/table_handle_jdbc_client_caching
branch
from
eda2b10 to
e8bc529
Compare
findepi
approved these changes
Oct 26, 2022
|
Is this a user-visible change? I.e. do we need any release notes for this? |
|
I've doublechecked and seems caching jdbc client is always enabled and end users mostly not interested in this change. |
on per-query basis, yes
unless this fixes a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table handle contains column handles. When column is changed, data in cache for table handles is stale.
Test TableHandles cache invalidation on columns change.
Description
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: