Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventDrivenTaskSource record split time #14785

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

Dith3r
Copy link
Member

@Dith3r Dith3r commented Oct 27, 2022

Description

getSplitTimeRecorder expects start time of operation, and it needs to be defined in nanoseconds.

Non-technical explanation

Scheduler statistics for splitting can present invalid information because use of inconsistent time units.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Oct 27, 2022
@Dith3r Dith3r marked this pull request as ready for review October 27, 2022 06:53
@Dith3r Dith3r changed the title Fix for EventDrivenTaskSource unit difference for record split time Fix EventDrivenTaskSource record split time Oct 27, 2022
@Dith3r Dith3r requested a review from lukasz-stec October 27, 2022 08:27
Copy link
Member

@lukasz-stec lukasz-stec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@arhimondr arhimondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@arhimondr arhimondr merged commit 0b38a40 into trinodb:master Oct 27, 2022
@github-actions github-actions bot added this to the 402 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants