Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some housekeeping dependency updates #14809

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Some housekeeping dependency updates #14809

merged 5 commits into from
Nov 1, 2022

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Oct 27, 2022

Description

Some dependency updates for housekeeping.

Non-technical explanation

Some dependency updates for housekeeping.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@hashhar
Update Druid JDBC driver version
c3be6cb
@hashhar
Update protobuf-java version in Pinot connector
df1efcb
@hashhar
Update Redshift JDBC driver
b14d157 
The newer driver fixes some issues with metadata queries where incorrect
data type or precision/decimal digits can be returned
@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label Oct 27, 2022
@cla-bot cla-bot bot added the cla-signed label Oct 27, 2022
@hashhar hashhar marked this pull request as ready for review October 27, 2022 15:23
tooptoop4
tooptoop4 reviewed Oct 27, 2022
View reviewed changes
pom.xml
@@ -51,7 +51,7 @@
<dep.antlr.version>4.11.1</dep.antlr.version>
<dep.airlift.version>219</dep.airlift.version>
<dep.packaging.version>${dep.airlift.version}</dep.packaging.version>
<dep.aws-sdk.version>1.12.172</dep.aws-sdk.version>
<dep.aws-sdk.version>1.12.261</dep.aws-sdk.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.12.322

@hashhar
Update AWS Java SDK to address CVE-2022-31159
03d6642 
Note that Trino doesn't use TransferManager and is not actually affected.
@hashhar hashhar force-pushed the hashhar/housekeeping branch from ffa0a24 to 03d6642 Compare October 28, 2022 10:42
@hashhar hashhar requested a review from ebyhr October 31, 2022 10:14
@hashhar
Copy link
Member Author

hashhar commented Nov 1, 2022

Interesting failure - looks like a Databricks problem though. The driver received a Retry-After response with no value. Will see if a newer driver version is available.

It's flakiness so merging anyway.

tests               | 2022-10-31 23:52:28 INFO: FAILURE     /    io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility.testDatabricksUsesCheckpointInterval (Groups: profile_specific_tests, delta-lake-databricks) took 7.0 seconds
tests               | 2022-10-31 23:52:28 SEVERE: Failure cause:
tests               | io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: [Databricks][DatabricksJDBCDriver](500593) Communication link failure. Failed to connect to server. Reason: HTTP retry after response received with no Retry-After header, error: HTTP Response code: 503, Error message: Unknown.
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$3.lambda$executeQuery$0(QueryExecutors.java:141)
tests               | 	at net.jodah.failsafe.Functions.lambda$get$0(Functions.java:48)
tests               | 	at net.jodah.failsafe.RetryPolicyExecutor.lambda$supply$0(RetryPolicyExecutor.java:62)
tests               | 	at net.jodah.failsafe.Execution.executeSync(Execution.java:129)
tests               | 	at net.jodah.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:376)
tests               | 	at net.jodah.failsafe.FailsafeExecutor.get(FailsafeExecutor.java:67)
tests               | 	at io.trino.tests.product.utils.QueryExecutors$3.executeQuery(QueryExecutors.java:141)
tests               | 	at io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility.testDatabricksUsesCheckpointInterval(TestDeltaLakeDatabricksCheckpointsCompatibility.java:237)
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
tests               | 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
tests               | 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
tests               | 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
tests               | 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
tests               | 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
tests               | 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
tests               | 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
tests               | 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
tests               | 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
tests               | 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
tests               | 	at java.base/java.lang.Thread.run(Thread.java:833)
tests               | Caused by: java.sql.SQLException: [Databricks][DatabricksJDBCDriver](500593) Communication link failure. Failed to connect to server. Reason: HTTP retry after response received with no Retry-After header, error: HTTP Response code: 503, Error message: Unknown.
tests               | 	at com.databricks.client.hivecommon.api.HS2Client.handleTTransportException(Unknown Source)
tests               | 	at com.databricks.client.spark.jdbc.DowloadableFetchClient.handleTTransportException(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.api.HS2Client.executeStatementInternal(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.api.HS2Client.executeStatement(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.dataengine.HiveJDBCNativeQueryExecutor.executeRowCountQueryHelper(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.dataengine.HiveJDBCNativeQueryExecutor.execute(Unknown Source)
tests               | 	at com.databricks.client.jdbc.common.SStatement.executeNoParams(Unknown Source)
tests               | 	at com.databricks.client.jdbc.common.BaseStatement.execute(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.jdbc42.Hive42Statement.execute(Unknown Source)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:128)
tests               | 	at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:112)
tests               | 	... 22 more
tests               | 	Suppressed: java.lang.Exception: Query: INSERT INTO default.test_dl_checkpoints_compat_1gh8frbmwcz7 VALUES (1, 'databricks')
tests               | 		at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:136)
tests               | 		... 23 more
tests               | Caused by: com.databricks.client.support.exceptions.ErrorException: [Databricks][DatabricksJDBCDriver](500593) Communication link failure. Failed to connect to server. Reason: HTTP retry after response received with no Retry-After header, error: HTTP Response code: 503, Error message: Unknown.
tests               | 	... 33 more
tests               | Caused by: com.databricks.client.jdbc42.internal.apache.thrift.transport.TTransportException: HTTP retry after response received with no Retry-After header, error: HTTP Response code: 503, Error message: Unknown
tests               | 	at com.databricks.client.hivecommon.HttpRetrySettings.shouldRetry(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.api.HS2ClientWrapper.shouldReexecuteRequest(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.api.HS2ClientWrapper.executeWithRetry(Unknown Source)
tests               | 	at com.databricks.client.hivecommon.api.HS2ClientWrapper.ExecuteStatement(Unknown Source)
tests               | 	... 31 more

@hashhar hashhar merged commit e98e17a into master Nov 1, 2022
@hashhar hashhar deleted the hashhar/housekeeping branch November 1, 2022 06:19
@ebyhr
Copy link
Member

ebyhr commented Nov 1, 2022

It's known issue and even latest driver doesn't resolve the failure #14391

@github-actions github-actions bot added this to the 402 milestone Nov 1, 2022
@colebow colebow mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooptoop4 tooptoop4 tooptoop4 left review comments

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
402
Development

Successfully merging this pull request may close these issues.
3 participants
@hashhar @ebyhr @tooptoop4