Expose test containers' hostnames on custom networks #14855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
Nov 1, 2022
...ng/trino-testing-containers/src/main/java/io/trino/testing/containers/BaseTestContainer.java
Outdated
Show resolved
Hide resolved
jacobbaskin
force-pushed
the
network-alias-testcontainers
branch
from
aa32313 to
8a7643d
Compare
hashhar
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On some Docker environment, tests that rely on communication between Docker containers using a custom
network (e.g. those using
HiveMinioDataLake) fail. This change ensures that, in this situation, containersare always configured to expose their hostname as a DNS alias over Docker custom networks.
Non-technical explanation
Ensure that tests using multiple Docker containers are reproducible on non-continuous-build environments
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: