Make version OptionalInt in AbstractIcebergTableOperations
#14938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
force-pushed
the
make-version-optionalInt
branch
from
82862bb to
98c804e
Compare
krvikash
changed the title
AbstractIcebergTableOperations
krvikash
force-pushed
the
make-version-optionalInt
branch
2 times, most recently
from
5695219 to
a0f2cc2
Compare
alexjo2144
suggested changes
Nov 9, 2022
...iceberg/src/main/java/io/trino/plugin/iceberg/catalog/file/FileMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
...o-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/GlueIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
...berg/src/main/java/io/trino/plugin/iceberg/catalog/hms/AbstractMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
...-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/HiveMetastoreTableOperations.java
Outdated
Show resolved
Hide resolved
krvikash
added
the
no-release-notes
krvikash
force-pushed
the
make-version-optionalInt
branch
2 times, most recently
from
dde38b0 to
ece72f3
Compare
krvikash
force-pushed
the
make-version-optionalInt
branch
from
ece72f3 to
ddadb20
Compare
|
Hi @ebyhr, Requires cloud tests to run against this PR. |
|
Sent #14980 within the repository. |
|
CI hit #13199 |
findinpath
approved these changes
Nov 10, 2022
ebyhr
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14919
Non-technical explanation
NA
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: