Add multipleWritersPerPartitionSupported flag in ConnectorTableLayout + Refactor scale writer #14956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Nov 9, 2022
|
@arhimondr @findepi ptal if you want |
sopel39
changed the title
findepi
reviewed
Nov 9, 2022
findepi
reviewed
Nov 9, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
This new flag helps the engine to identify whether writer scaling per partition is allowed.
Previously physicalWrittenBytesSupplier was passed directly to the LocalExchange constructor, thus it was hard to map a buffer to its respective writer physical written bytes. However, with this change we are passing it directly while operator get its next buffer. This refactor will be helpful for scaling partitioned writes with skewness.
Instead of using SystemPartitioningHandle for scale writers partitioning, introduce a separate flag inside PartitioningHandle. This will eventually help us enable scale writers for any kind of partitioning like a connector specific partitioning.
arhimondr
approved these changes
Nov 9, 2022
sopel39
approved these changes
Nov 10, 2022
| this(partitioning, partitionColumns, false); | ||
| } | ||
|
|
||
| public ConnectorTableLayout(ConnectorPartitioningHandle partitioning, List<String> partitionColumns, boolean multipleWritersPerPartitionSupported) |
There was a problem hiding this comment.
nit: this method would most likely be used with multipleWritersPerPartitionSupported=true. We could consider switching to static constructor methods in the future
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extracted 4 commits from #14718
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: