Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the DML operations support on GCS #14985

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

findinpath
Copy link
Contributor

Description

Left-over docs change for Delta DML operation support on GCS from #14766

Non-technical explanation

N/A

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@@ -566,6 +566,13 @@ Write operations are supported for tables stored on the following systems:
detects write collisions on ADLS Gen2 when writing from multiple Trino
clusters, or from as any number of open source Delta Lake clusters.

* Google Cloud Storage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is treated the same as Azure ADLS, we can probably combine them into one bullet point, e.g. * Azure ADLS Gen2, Google Cloud Storage

Then "Writes to the Azure ALDS Gen2 and Google Cloud Storage file systems are enabled..."

Comment on lines 566 to 567
detects write collisions on ADLS Gen2 when writing from multiple Trino
clusters, or from as any number of open source Delta Lake clusters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
detects write collisions on ADLS Gen2 when writing from multiple Trino
clusters, or from as any number of open source Delta Lake clusters.
detects write collisions on ADLS Gen2 when writing from multiple Trino
or Delta Lake clusters.

I can't figure out what this is trying to say and I don't think we need to tell people that Delta Lake is open source here, so let's clean it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote a bit this statement to be a bit more concise, but still tried to keep its essence.

@findinpath findinpath force-pushed the docs/delta-gcs-update-data branch from b312cc2 to 5966a0f Compare November 14, 2022 05:43
@findinpath findinpath requested a review from colebow November 14, 2022 05:43
@findinpath findinpath requested a review from ebyhr November 16, 2022 07:09
docs/src/main/sphinx/connector/delta-lake.rst Outdated Show resolved Hide resolved
@findinpath findinpath force-pushed the docs/delta-gcs-update-data branch from 5966a0f to 862b18f Compare November 17, 2022 11:08
@findinpath findinpath requested a review from ebyhr November 17, 2022 11:09
@ebyhr ebyhr force-pushed the docs/delta-gcs-update-data branch from 862b18f to ca606ec Compare November 17, 2022 23:02
@ebyhr ebyhr merged commit 8d24eca into trinodb:master Nov 18, 2022
@github-actions github-actions bot added this to the 404 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants