Fix set-milestone failure when latest milestone is closed #15054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can be situation where the latest milestone is closed but there are still some PRs for which this workflow is pending. The API by default only lists open milestones. This commit changes it to list all milestones so that even if the target milestone is closed it can be found and the PR added to it.
nineinchnick
approved these changes
Nov 16, 2022
|
I'll test this on my fork if possible. It should work though. |
martint
approved these changes
Nov 16, 2022
ebyhr
approved these changes
Nov 16, 2022
|
No easy way to test but I did test the API manually and it's possible to add things to closed milestones. I'll keep an eye in case of failures, merging this. |
hashhar
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There can be situation where the latest milestone is closed but there are still some PRs for which this workflow is pending. The API by default only lists open milestones. This commit changes it to list all milestones so that even if the target milestone is closed it can be found and the PR added to it.
Non-technical explanation
Fix occasional set-milestone failure.
Release notes
(x) This is not user-visible or docs only and no release notes are required.