Remove outdated SPI revapi exclusions #15077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
no-release-notes
sopel39
approved these changes
Nov 17, 2022
losipiuk
approved these changes
Nov 17, 2022
findepi
deleted the
findepi/remove-outdated-spi-revapi-exclusions-53b420
branch
findepi
commented
Nov 17, 2022
| @@ -210,60 +210,6 @@ | |||
| </item> | |||
| <!-- Backwards incompatible changes since the previous release --> | |||
| <!-- Any exclusions below can be deleted after each release --> | |||
| <item> | |||
| <code>java.method.numberOfParametersChanged</code> | |||
| <old>method void io.trino.spi.eventlistener.QueryStatistics::<init>(java.time.Duration, java.time.Duration, java.time.Duration, java.time.Duration, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, java.util.Optional<java.time.Duration>, long, long, long, long, long, long, long, long, long, long, long, long, long, long, long, double, double, java.util.List<io.trino.spi.eventlistener.StageGcStatistics>, int, boolean, java.util.List<io.trino.spi.eventlistener.StageCpuDistribution>, java.util.List<java.util.Optional<io.trino.spi.metrics.Distribution<?>>>, java.util.List<java.lang.String>, java.util.Optional<java.lang.String>) | |||
There was a problem hiding this comment.
We could avoid having these entries here at all.
Here is the proposal: #15078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.