Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for MERGE with row filters #15102

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Add tests for MERGE with row filters #15102

merged 4 commits into from
Nov 18, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 18, 2022 •
edited by ebyhr
Loading

Fixes #15101

@findepi
Improve code comments in TestRowFilter
e52fbf2
@findepi
Remove duplicated test case
bf922c1 
It's identical with the preceding one.
@findepi
Fix error message when MERGE into table with row filters
84ed4bd 
The message was not a sentence.
@findepi
Add tests for MERGE with row filters
68bdcc9 
Add coverage for MERGE in `TestRowFilter`.
@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Nov 18, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 18, 2022
@findepi findepi mentioned this pull request Nov 18, 2022
Merged
kokosing
kokosing approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about column masking?

@findepi
Copy link
Member Author

findepi commented Nov 18, 2022

What about column masking?

Good idea, someone can do this too.

@findepi findepi merged commit 8ad35c0 into trinodb:master Nov 18, 2022
@findepi findepi deleted the findepi/test-row-filter branch November 18, 2022 21:16
@hashhar hashhar added this to the 404 milestone Nov 19, 2022
@colebow colebow mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

@losipiuk losipiuk losipiuk approved these changes

@djsstarburst djsstarburst Awaiting requested review from djsstarburst

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Milestone
405
Development

Successfully merging this pull request may close these issues.

Add MERGE test to io.trino.sql.query.TestRowFilter
4 participants
@findepi @losipiuk @kokosing @hashhar